Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
MythicCrucible MythicCrucible
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 53
    • Issues 53
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • MythicCraft
  • MythicCrucibleMythicCrucible
  • Issues
  • #227

Closed
Open
Created Jul 18, 2024 by Lithid@LitridDeveloper

Stats tooltips appear incorrectly

Summary

When using static/setter stats modifiers on items, the tooltips do not appear correctly on items.

Steps to reproduce

Here is the ATTACK_DAMAGE stat that will be used in both examples:

ATTACK_DAMAGE:
  Enabled: true
  AlwaysActive: false
  Display: '<#AEC6CF>Damage'
  Tooltips:
    Additive: '+<value> Damage'
    Multiply: '+<value> Damage'
    Compound: 'x<value> Damage'
    Setter: '<display>: <value>'
    Rounding: 0
  BaseValue: 1

Here is the first item, with its attached lore template:

WarriorsSword:
  Template: Weapon
  Display: <gray><bold>Warrior's Sword
  Model: 1
  Generation: item/warriors_sword
  Stats: 
  - ATTACK_DAMAGE 9 SETTER
  - ATTACK_SPEED 1.0 SETTER
  - CRITICAL_STRIKE_CHANCE 0.25 SETTER
  - CRITICAL_STRIKE_DAMAGE 0.56 SETTER
  Skills:
  - skill{s=SwordAttack} @self ~onSwing
  Lore:
    Template: Weapon
    Rarity: <gray><bold>Common
    Abilities: <dark_gray>A blade forged for warriors...
Weapon:
  Lines:
  - <lore.Rarity>
  - <dark_gray><st>-----------------------
  - <lore.stats>
  - <dark_gray><st>⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
  - <lore.Abilities>

And here is the second item which will be used as an example:

WarriorsSword:
  Display: <gray><bold>Warrior's Sword
  Model: 1
  Generation: item/warriors_sword
  Stats: 
  - ATTACK_DAMAGE 9 SETTER
  - ATTACK_SPEED 1.0 SETTER
  - CRITICAL_STRIKE_CHANCE 0.25 SETTER
  - CRITICAL_STRIKE_DAMAGE 0.56 SETTER
  Skills:
  - skill{s=SwordAttack} @self ~onSwing
  Lore:
    - <stat.ATTACK_DAMAGE>

Current behavior

Here is what the first item appears as:

image

And here is what the second item appears as:

image

Intended correct behavior

The first item should both have the attack damage stat shown as ": ", however it is instead shown as "Force . Note that I have also tried using Static: instead of Setter:.

For the second item, not only does it not use the tooltip, but it also doesn't apply the color codes in the display.

And for both items the rounding isn't performed properly.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking