Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
MythicMobs MythicMobs
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 132
    • Issues 132
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • MythicCraft
  • MythicMobsMythicMobs
  • Issues
  • #553

Closed
Open
Created Sep 20, 2021 by Luis Antonio H. Larrosa@RumiExMachina⚙Reporter

[MythicLib] Citizens NPCs are counted as Players

Summary

The plugin MythicLib tries to get data from a PLAYER NPC from Citizens, in case of death and combat, MythicLib cannot fetch the data and throws errors in the console. Related plugins are: MythicLib, Citizens and Sentinel (Sentinel due it allowing NPCs to fight, causing the error).

Non Player NPCs are not affected by this issue.

Steps to reproduce

  1. Create a Citizen NPC with is damageable or have the Sentinel trait.
  2. Make the Citizen NPC attack/be attacked by an entity / killed.
  3. Check console for MythicLib errors.

Current behavior

Basically MythicLib is trying to fetch data from a Citizen NPC thinking its a player, causing data error and spamming the console with errors.

Intended correct behavior

MythicLib shouldn't count as players Citizens NPCs.

Server log file

https://pastebin.com/AYnpaxa5

Proposed fixes

Make MythicLib ignore NPCs so they are not counted as players, that way Citizen NPCs will be able to fight/die/kill properly when using this setup.

Edited Sep 20, 2021 by Luis Antonio H. Larrosa
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking