Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
MythicMobs MythicMobs
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 132
    • Issues 132
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • MythicCraft
  • MythicMobsMythicMobs
  • Issues
  • #768

Closed
Open
Created Apr 09, 2022 by PirateSoftware@PirateSoftware

Passing a placeholder to currencygive is always increasing player money by 1 regardless of the passed value.

Summary

Passing a placeholder to currencygive is always increasing player money by 1 regardless of the passed value. Passing the same placeholder into an eco or message command shows the placeholder is correctly set to values higher than 1.

Steps to reproduce

Increases the players money by 1 regardless of input
- currencygive{amount=<skill.var.split>}

Increases the players money by the correctly set placeholder amount
- command{c="eco give <target.name> <skill.var.split>"}

Example Mob

ZOMBIE:
  Modules:
    ThreatTable: true
  Skills:
  - setVariable{var=caster.coin;type=FLOAT;value=3} @Self ~onSpawn
  - skill{s=GlobalPayout} @ThreatTablePlayers ~onDeath

Example Working Currency Split - command eco

GlobalPayout:
  Conditions:
  - incombat true
  Skills:
  - setVariable{var=skill.split;type=FLOAT;value=0} @Self
  - variableMath{var=skill.split;equation="<caster.var.coin>/<skill.targets>"}
  - command{c="eco give <target.name> <skill.var.split>"}

Example Broken Currency Split - currencygive

GlobalPayout:
  Conditions:
  - incombat true
  Skills:
  - setVariable{var=skill.split;type=FLOAT;value=0} @Self
  - variableMath{var=skill.split;equation="<caster.var.coin>/<skill.targets>"}
  - currencygive{c=<skill.var.split>}

Current behavior

This prevents me from setting up currency splits without spamming eco commands. This fills the server log and spams players chats.

Intended correct behavior

The float passed to currencygive should be used to increase the players money.

Server log file

There is no associated error with this bug.

Debug log snippet

There is no associated debug information with this bug.

Proposed fixes

Accept placeholder inputs into currencygive.

Edited Apr 09, 2022 by PirateSoftware
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking