Ignore-armour damage not hurting mobs through damage-resistance effect.

Summary

  • Ignore armour damage fails to kill a mob when the mob has damage resistance 5 potion effect on them.

Steps to reproduce

  • Download (at earliest) dev build 3551.

  • Paste the mob in the pastebin below into the mob folder.

  • Spawn the mob and right-click it.

  • Mob: https://pastebin.com/UjxxMR4g

Current behavior

  • Right clicking the mob fails to kill it, despite the damage being higher than the mob's health.
  • No matter how many times this is repeated, the mob doesn't die.
  • Two damage numbers pop-up when some sort of damage indicator is used (e.g. MMOItems)
  • https://gyazo.com/1541bcab6486ca223c1370f60311c480

Intended correct behavior

  • The mob should die.
  • The correct behaviour can be seen in dev-build 3550.

Server log file

https://pastebin.com/v5Gh8F5k

Debug log snippet

https://pastebin.com/EeEAA5a2 Right-clicked the mob 5 times, hence 5 repeated outputs.

Proposed fixes

Since the issue arises in dev 3551, and this version fixed #285 (closed), I can only presume that this fix somehow breaks ignore-armour damage for potion effects.