Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
MythicMobs MythicMobs
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 132
    • Issues 132
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • MythicCraft
  • MythicMobsMythicMobs
  • Issues
  • #201

Closed
Open
Created Dec 01, 2020 by Alex@Crysillion

Allow placeholders in the value field of variableInRange

Summary

Spoke about this on Discord, but I realize there's tons of tickets and not everyone may have read it so I'll explain.

When I was using MMOCore, there was a built-in feature where abilities could critically hit. Unfortunately, this ability only works with built-in abilities, so skills that I make through MythicMobs aren't eligible.

It was suggested that I can likely emulate this effect using variableInRange and generating a random number. Hey, that's a good idea. I can grab the players Spell Critical Strike Rate, push that into a number, compare it to a randomly generated number between 1-100, and if it's within a certain range, do a castInstead for a stronger version of an ability. Boom. "Critical Strikes" in skills!

In my series of unfortunate events, I ran into another wall.

  • variableInRange{var=caster.rollvalue;value=>50} castinstead smite2

The value field doesn't accept variables. Indeed, what's posted above works. But if I do something like this...

  • variableInRange{var=caster.rollvalue;value=><caster.var.atk>} castinstead smite2

It breaks. It's been confirmed that the value field doesn't accept variables or placeholders, so I'd like to suggest that it does.

Usage

There's a lot of integration one could use with MMOCore hooking into MythicMobs abilities with more placeholder freedom in general, but I digress, I'm specifically having a problem with the value field of variableInRange.

Value

I'll be brutally honest, it feels like I'm the only person who even cares about this sort of thing lol, so I guess it wouldn't actually do much for the overall userbase.

Priority

MAXIMUM PRIORITY obviously, lol. Nah, whenever you get around to it, as it goes.

Implementation

The value field currently only accepts flat numbers, if it could accept placeholders and/or variables, that'd be pretty cool. Stuff like damage already does, so does duration, for example.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking