Skip to content

GitLab

Open
Created by LoneDevilX@LoneDevilX

Threattable bug (two bug noticed)

Summary

  1. BUG on Threat table name for specific drop https://git.lumine.io/mythiccraft/MythicMobs/-/wikis/UsefulTips will show the name of same person @ThreatTablePlayers{limit=1;sort=HIGHEST_THREAT}. Top 1 is fine, just top 2 and 3 will be same person (if theres only two player hitting the boss)

Example: if theres only two player slain the boss: Top 1 = ABC Top 2 = YSL Top 3 = YSL (incorrect)

  1. BUG on Threat table player for droptable, putting <trigger.name> will give the reward to the top 1, putting <target.name> will show error: [18:33:46 INFO]: Can't find player with this name! ([name]) (Class -> Unknown)

Steps to reproduce

FIRST BUG:

  1. https://pastebin.com/QNnGhtkz
  2. /mm reload
  3. spawn the mob to test with survival mode
  4. If 2 player slain the boss will show Top 1 = ABC ; Top 2 = YSL ; Top 3 = YSL (incorrect) Picture : image
  5. If 3 player slain the boss will show correctly Top 1 = ABC ; Top 2 = YSL ; Top 3 = DEF Picture : image
  6. If 3 player slain the boss , one of them offline, it will exit from the ThreatTable Picture : image
  7. Then I add stuti=1/=2 https://pastebin.com/6VamvkFL, works properly.

SECOND BUG:

  1. example droptable https://pastebin.com/qnLheNKv using <target.name>
  2. /mm reload
  3. spawn mob and test with survival mode
  4. I am using as skill https://pastebin.com/6VamvkFL, it works well for Top 1 to Top 3 no matter how less player testing
  5. show error : https://pastebin.com/RQUDhN5p

OR

  1. example droptable https://pastebin.com/05VC3wHB using <trigger.name>
  2. /mm reload
  3. spawn mob and test with survival mode
  4. I am using as skill https://pastebin.com/6VamvkFL, it works well for Top 1 to Top 3 no matter how less player testing
  5. all reward will only give to TOP 1

Current behavior

FIRST BUG: the leaderboard does not show correct name. and the reward will be given to the same person (top 2 & top 3). Each of the top should have their specific reward instead of receiving two.

**SECOND BUG: **The reward is given to Top 1, and Top 2-3 does not receive any reward.

Intended correct behavior

FIRST BUG: the leaderboard should show correct sequence of name even tho its 2 player.

**SECOND BUG: **Each reward should be given to Top 1, Top 2 and Top 3. No duplicated reward given.

Server log file https://pastebin.com/Nx5A2t8K

Debug log snippet

https://pastebin.com/m4W4jZ6p

Proposed fixes

Just fix the <trigger.name> and im not sure https://pastebin.com/QNnGhtkz should works correctly before this?