Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
MythicMobs MythicMobs
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 136
    • Issues 136
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • MythicCraft
  • MythicMobsMythicMobs
  • Issues
  • #1361

Closed
Open
Created Oct 19, 2023 by Zackary Blair@Paintsplatters

Mythic Mobs hasitem condition no longer works for mmoitems in 5.4.1 premium stable

Summary

The hasitem condition is not recognizing mmoitems anymore since i updated to 5.4.1 premium stable.

Plugin and Server versions I use Paper 1.20.1 196. MMOItems 6.9.4, Mythic Lib 1.6, Mythic Mobs Premium 5.3.5 (for correct behavior) and 5.4.1 (for broken behavior)

How to replicate the issue

Have MMOItems 6.9.4, Mythic Lib 1.6 and MythicMobs 5.4.1 installed.

Create a skill with the conditon:

  Conditions:
  - hasitem{i=mmoitems.TYPE.ID} true

replacing type.id with some mmoitem you have configured.

Trigger a command or ability to cast the "lootcrate_common" skill while not having that mmoitem in your inventory.

The skill will trigger and run the skill mechanics, bypassing the given hasitem condition

Intended correct behavior

The skill mechanics should not execute because the hasitem condition is not met.

Server Log

https://paste.denizenscript.com/View/116631 (had to use different paste service. Log was too big for pastebin)

Debug log snippet

https://paste.denizenscript.com/View/116633

Proposed fixes

Check what is causing the condition to be ignored, or always return true when it shouldn't and correct the issue in MM code.

Edited Oct 19, 2023 by Zackary Blair
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking