GitLab

Summary

-> Minecraft version 1.19.2, MythicMobs free version 5.2.0-038019e5

Fireworks don't load from item file since MythicMobs v5.2.0. It worked before that.

Steps to reproduce

1. Take a firework (empty or with colors, doesn't matter).
2. /mm items import fireworktest.
3. /mm items give <name> fireworktest.

Current behavior

The firework is saved but no longer loads. Further, the file does not look like the Firework format from wiki. This wiki doesn't describe how to add an explosion effect (star, large ball, ...) so I cannot reproduce my item manually.

If you need an example of small firework

test6:
  ItemStack:
    ==: org.bukkit.inventory.ItemStack
    v: 3120
    type: FIREWORK_ROCKET
    meta:
      ==: ItemMeta
      meta-type: FIREWORK
      firework-effects:
      - ==: org.bukkit.FireworkEffect
        flicker: false
        trail: true
        colors:
        - ==: org.bukkit.Color
          RED: 51
          BLUE: 255
          GREEN: 214
        fade-colors: []
        type: BALL_LARGE

Small stack trace of the error

[18:17:04 INFO]: cricri_21 issued server command: /mm items import fireworktest
[18:17:04 WARN]: [MythicMobs] ✗ Configuration Error in Item fireworktest
[18:17:04 WARN]: [MythicMobs] --| File: D:\...\plugins\MythicMobs\Items\fireworktest.yml
[18:17:04 WARN]: [MythicMobs] --| Error Message: Couldn't get name/lore of ItemStack
[18:17:10 INFO]: cricri_21 issued server command: /mm items give cricri_21 fireworktest
[18:17:10 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'mm' in plugin MythicMobs v5.2.0-038019e5
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:155) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.v1_19_R1.CraftServer.dispatchCommand(CraftServer.java:916) ~[paper-1.19.2.jar:git-Paper-182]
        at org.bukkit.craftbukkit.v1_19_R1.command.BukkitCommandWrapper.run(BukkitCommandWrapper.java:64) ~[paper-1.19.2.jar:git-Paper-182]
        at com.mojang.brigadier.CommandDispatcher.execute(CommandDispatcher.java:264) ~[paper-1.19.2.jar:?]
        at net.minecraft.commands.Commands.performCommand(Commands.java:305) ~[?:?]
        at net.minecraft.commands.Commands.performCommand(Commands.java:289) ~[?:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.performChatCommand(ServerGamePacketListenerImpl.java:2293) ~[?:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$20(ServerGamePacketListenerImpl.java:2247) ~[?:?]
        at net.minecraft.util.thread.BlockableEventLoop.lambda$submitAsync$0(BlockableEventLoop.java:59) ~[?:?]
        at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?]
        at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.19.2.jar:git-Paper-182]
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?]
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1341) ~[paper-1.19.2.jar:git-Paper-182]
        at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:185) ~[paper-1.19.2.jar:git-Paper-182]
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?]
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1318) ~[paper-1.19.2.jar:git-Paper-182]
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1311) ~[paper-1.19.2.jar:git-Paper-182]
        at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?]
        at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1289) ~[paper-1.19.2.jar:git-Paper-182]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1177) ~[paper-1.19.2.jar:git-Paper-182]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:305) ~[paper-1.19.2.jar:git-Paper-182]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.IllegalStateException: Cannot make FireworkEffect without any color
        at org.bukkit.FireworkEffect.<init>(FireworkEffect.java:326) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.FireworkEffect$Builder.build(FireworkEffect.java:305) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
        at io.lumine.mythic.core.items.MythicItem.buildFirework(MythicItem.java:969) ~[MythicMobs-5.2.0.jar:?]
        at io.lumine.mythic.core.items.MythicItem.generateItemStack(MythicItem.java:759) ~[MythicMobs-5.2.0.jar:?]
        at io.lumine.mythic.bukkit.commands.items.GiveCommand.onCommand(GiveCommand.java:101) ~[MythicMobs-5.2.0.jar:?]
        at io.lumine.mythic.bukkit.utils.commands.Command.onCommand(Command.java:64) ~[MythicMobs-5.2.0.jar:?]
        at io.lumine.mythic.bukkit.utils.commands.Command.onCommand(Command.java:55) ~[MythicMobs-5.2.0.jar:?]
        at io.lumine.mythic.bukkit.utils.commands.Command.onCommand(Command.java:55) ~[MythicMobs-5.2.0.jar:?]
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
        ... 23 more

---

There is also this annoying warning that pops up on every MythicMobs (re)loads when we save any items without lore :

[18:37:43 WARN]: [MythicMobs] ✗ Configuration Error in Item anyitem
[18:37:43 WARN]: [MythicMobs] --| File: D:\...\plugins\MythicMobs\Items\anyitem.yml
[18:37:43 WARN]: [MythicMobs] --| Error Message: Couldn't get name/lore of ItemStack