Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
MythicDungeons MythicDungeons
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 84
    • Issues 84
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • MythicCraft
  • MythicDungeonsMythicDungeons
  • Issues
  • #279

Closed
Open
Created Sep 23, 2023 by Complex@Complex

[Suggestion] Consider MMOItems Revision IDs in loot tables

Currently, when you place MMOItems in loot tables, it only copies the data of the placed item at that specific time. Therefore, when the revision ID of an MMOItem is updated, the items in MD loot tables are not updated - they still have the items with the old revision ID. This causes issues such as the item being outdated, the items not stacking, etc...

It would be great for MD to store codenames of MMOItems placed in loot tables, so that when MD generates loot tables, it will reference the MMOItems plugin for the latest revisions of those items (they have a method in their API to retrieve the newest ItemStack given an MMOItems codename).

If you are not aware of what revision IDs in MMOItems are, here is an explanation: Let's say you have a stick with attack damage 2 and custom model data 300 for example. The revision ID of this item is 1

You can bump up the attack damage to 4 and change the custom model data to 500, and change any other attributes, and bump the revision ID to 2.

This means that the next time the item is updated (such as dropping and picking up the item), the stick will now have the new attributes you set.

Edited Sep 23, 2023 by Complex
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking